100 UI admin site maintenance notifications #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
create model for a site notification
add notification to db_connection
Add notifications api endpoints
|
@schmelz21 According to @rapidray12 any newly created endpoints are blocked until a particular team unblocks them. In order to not mess up staging, one possibility would be to revert the new /admin-tools endpoint to the use the existing /scans one until /admin-tools is available for use. What do you think? |
update the app file to manage the new notification endpoints
update api request type for create
Remove auth permission to view notification
Change location of notifications app api
remove typo
ameliav
added
the
blocked
|
Blocked: implementation of stopping logins is blocked |
…nce windows if not globalAdmin user.
ameliav
removed
the
blocked
ameliav
requested review from
aloftus23,
cduhn17,
Matthew-Grayson,
nickviola,
rapidray12 and
schmelz21
as code owners
JCantu248
approved these changes
May 14, 2024
schmelz21
approved these changes
May 14, 2024
|
UAT results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
The Admin site maintenance tool should allow administrators to manage site maintenance messages. And create a method to issue a site management page. These messages will be displayed to users during scheduled maintenance on the login page and/or when there are critical update a maintenance page will display.
💭 Motivation and context
This is valuable to streamline the maintenance processes for Crossfeed.
🧪 Testing
📷 Screenshots
No active or inactive notifications screen
Active notification and inactive notifications
Add New notification card and validation
Update notification pop up and validation
Login Screen with an Active notification
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist